[asterisk-dev] [Code Review]: Sorcery retrieve_by_regex support

[wdoekes]

> On Feb. 14, 2013, 1:48 p.m., Matt Jordan wrote:
> > This is still good to go.
> 
> wdoekes wrote:
>     Seans remark about the docs still stand.
>     
>     And I wonder why we're doing insensitive by default. Switching to insensitive is always possible by extending your regex, the other way around isn't. Can't you pass a compiled regex to the regex_retrieve instead of a const char? Makes more sense to me than doing the regcomp this late. (Heck.. some other sourcery implementation might go with basic sensitive regex right now, and you wound't notice it.. until it breaks.)
>     
>     Then you can wrap it with a ast_sorcery_retrieve_by_regex_string_extended_insensitive() that takes a char* all you want.
>     
>

Disregard that last bit. I didn't think of backends (e.g. SQL) supporting their own regex comparisons.

That makes it all the more important to state what kind of regex we're using though.


- wdoekes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2329/#review7871
-----------------------------------------------------------


On Feb. 14, 2013, 9:52 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2329/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2013, 9:52 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This change adds a retrieve_by_regex API call to sorcery. It allows searching for multiple objects using a regular expression on the object identifier. This is useful if you have related objects and want to efficiently find them.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/sorcery.h 381399 
>   /trunk/main/sorcery.c 381399 
>   /trunk/res/res_sorcery_config.c 381399 
>   /trunk/res/res_sorcery_memory.c 381399 
>   /trunk/tests/test_sorcery.c 381399 
> 
> Diff: https://reviewboard.asterisk.org/r/2329/diff
> 
> 
> Testing
> -------
> 
> Ran unit test, confirmed happy.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130215/ba2e6370/attachment.htm>