[asterisk-dev] [Code Review] Pimp My SIP Media Improvements

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2318/
-----------------------------------------------------------

(Updated Feb. 12, 2013, 8:31 a.m.)


Review request for Asterisk Developers.


Changes
-------

Fixed a bug with SDP negotiation and also made it so RTP automatically chooses IPv6 or IPv4 for incoming sessions.


Summary
-------

These changes clean up media handling, move some more stuff into res_sip_sdp_audio, fixes a few bugs, and adds some additional features.

The act of negotiating an SDP media stream and actually applying the media stream are now separate operations.
Hold/unhold works.
RTP over IPv6 works.
Use of the 'ptime' attribute works.
Local Packet2Packet bridging works.
Symmetric RTP can now be enabled per-endpoint.
Reduced memory pool usage.
Fixed bug where the RTP instance was never destroyed.


Diffs (updated)
-----

  /team/group/pimp_my_sip/channels/chan_gulp.c 381276 
  /team/group/pimp_my_sip/configs/res_sip.conf.sample 381276 
  /team/group/pimp_my_sip/include/asterisk/res_sip.h 381276 
  /team/group/pimp_my_sip/include/asterisk/res_sip_session.h 381276 
  /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 381276 
  /team/group/pimp_my_sip/res/res_sip_sdp_audio.c 381276 
  /team/group/pimp_my_sip/res/res_sip_session.c 381276 

Diff: https://reviewboard.asterisk.org/r/2318/diff


Testing
-------

1. Sent and received calls from a few different devices
2. Held/unheld a call
3. Attempted to set up incompatible calls (only configured for gsm, but offering ulaw only)


Thanks,

Joshua

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130212/fd41af12/attachment.htm>