[asterisk-dev] [Code Review] Stopped spamming of debug messages during attended transfer

[jcolp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2324/#review7827
-----------------------------------------------------------


Two comments!

1. This is applicable to Asterisk 11 so don't forget to commit there eventually.
2. I think this is going to have the same logging issue when more than, oh, 2 channels are in autoservice for a noticeable period of time. The call-id is going to be changing around a lot.

- jcolp


On Feb. 8, 2013, 4:21 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2324/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2013, 4:21 p.m.)
> 
> 
> Review request for Asterisk Developers, jrose and Matt Jordan.
> 
> 
> Summary
> -------
> 
> While autoservice is running and servicing a channel the callid is being stored and removed in the thread's local storage for each iteration of the thread loop.  If debug was set to a sufficient level the log file would be spammed with callid thread local storage debug messages.  Added a new function that checks to see if the callid to be stored is different than what is already contained (if anything).  If it is different then store/replace and log, otherwise just leave as is.
> 
> 
> This addresses bug ASTERISK-21014.
>     https://issues.asterisk.org/jira/browse/ASTERISK-21014
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/logger.h 379127 
>   /trunk/main/autoservice.c 379127 
>   /trunk/main/logger.c 379127 
> 
> Diff: https://reviewboard.asterisk.org/r/2324/diff
> 
> 
> Testing
> -------
> 
> Reproduced the problem as per the issue, and then tested to make sure the problem no longer existed.  Also tested multiple calls/transfers from two phones at roughly the same time.
> 
> 
> Thanks,
> 
> Kevin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130211/53f9cf2f/attachment.htm>