[asterisk-dev] [Code Review]: Add aggregate operations for stuctures with string fields

[opticron]

> On Feb. 4, 2013, 3:12 p.m., Mark Michelson wrote:
> > trunk/include/asterisk/stringfields.h, lines 426-437
> > <https://reviewboard.asterisk.org/r/2308/diff/2/?file=33262#file33262line426>
> >
> >     As a memory saver, it would be a good idea to free all of the copy's string field pools before setting all of the string fields from the orig.
> >     
> >     Also this should return a pass/fail result.

Done and done.  I had to adjust some of the other macros here to also pass back success/failure information as well.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2308/#review7800
-----------------------------------------------------------


On Feb. 4, 2013, 1:08 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2308/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2013, 1:08 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This change adds aggregate operations on all string fields within a structure for copying and comparison to greatly simplify code which needs to do so.  Traditionally, this is done by copying or comparing each field individually.
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/stringfields.h 380806 
>   trunk/tests/test_stringfields.c 380806 
> 
> Diff: https://reviewboard.asterisk.org/r/2308/diff
> 
> 
> Testing
> -------
> 
> Passes the new unit tests that test these new aggregate operations (also in this review).
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130205/7e0cd51d/attachment.htm>