[asterisk-dev] [Code Review] Add aggregate operations for stuctures with string fields

opticron reviewboard at asterisk.org
Mon Feb 4 13:08:53 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2308/
-----------------------------------------------------------

(Updated Feb. 4, 2013, 1:08 p.m.)


Review request for Asterisk Developers.


Changes
-------

Fix the bug wdoekes found and make variable names more obscure to avoid possible name conflicts.


Summary
-------

This change adds aggregate operations on all string fields within a structure for copying and comparison to greatly simplify code which needs to do so.  Traditionally, this is done by copying or comparing each field individually.


Diffs (updated)
-----

  trunk/include/asterisk/stringfields.h 380806 
  trunk/tests/test_stringfields.c 380806 

Diff: https://reviewboard.asterisk.org/r/2308/diff


Testing
-------

Passes the new unit tests that test these new aggregate operations (also in this review).


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130204/fee97907/attachment.htm>


More information about the asterisk-dev mailing list