[asterisk-dev] [Code Review] Add variable length displayprompt packet to skinny and use octals

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2294/#review7792
-----------------------------------------------------------



/trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2294/#comment14779>

    Why not compare with '\200' to avoid the cast and the extra comment?



/trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2294/#comment14775>

    I'm not quite sure how the SCCP devices work with regards to this message.  Is this intentionally overwriting the null terminator of the octal string when writing extratext into the string?



/trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2294/#comment14778>

    Idem.



/trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2294/#comment14776>

    Idem.



/trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2294/#comment14777>

    Just to be on the safe side, strlen(extratext) should be conditionally added to packetlen only in the first branch above.  Relying on extratext to be "" when *text != '\200' could produce interesting bugs later on.


- opticron


On Feb. 1, 2013, 3:21 p.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2294/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2013, 3:21 p.m.)
> 
> 
> Review request for Asterisk Developers and Brad Latus.
> 
> 
> Summary
> -------
> 
> Add new variable length displayprompt packet (0x0145) to skinny. This uses a similar method to the variable length callinfo packet in https://reviewboard.asterisk.org/r/2290/. Uses the new packet if the device is reporting protocol versions >= 17.
> 
> Add the use of octal codes for sending prompts to both the new and old displayprompt messages (also cleaned up soft_key_template_default to use the defined octal codes).
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_skinny.c 380755 
> 
> Diff: https://reviewboard.asterisk.org/r/2294/diff
> 
> 
> Testing
> -------
> 
> Several calls on devices with protocol versions of 6 and 17. Prompts as expected.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130201/e462200a/attachment-0001.htm>