[asterisk-dev] [Code Review] 3095: chan_pjsip: add 'set_var' support on endpoints

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3095/#review10495
-----------------------------------------------------------



branches/12/channels/chan_pjsip.c
<https://reviewboard.asterisk.org/r/3095/#comment19950>

    I'm a little worried about this chopping off variables. For example, the buffer in chan_sip is 1024 - which may be excessive, but people do excessive things in their configurations sometimes.
    
    You may want to bump this to something a bit higher, such as 256 or 512.


- Matt Jordan


On Dec. 27, 2013, 5:28 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3095/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2013, 5:28 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-22868
>     https://issues.asterisk.org/jira/browse/ASTERISK-22868
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added a new 'set_var' option for ast_sip_endpoint(s).  For each variable specified that variable gets set upon creation of a pjsip channel involving the endpoint.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip/pjsip_configuration.c 404578 
>   branches/12/res/res_pjsip.c 404578 
>   branches/12/include/asterisk/res_pjsip.h 404578 
>   branches/12/configs/pjsip.conf.sample 404578 
>   branches/12/channels/chan_pjsip.c 404578 
> 
> Diff: https://reviewboard.asterisk.org/r/3095/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.  Testsuite test to come.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131231/8ee7e7c2/attachment.html>