[asterisk-dev] [Code Review] 3092: http: Properly reject requests with Transfer-Encoding set

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3092/
-----------------------------------------------------------

(Updated Dec. 24, 2013, 9:39 a.m.)


Review request for Asterisk Developers.


Changes
-------

Extract get_header function in http.c; fixed some copy/paste errors.


Bugs: ASTERISK-22486
    https://issues.asterisk.org/jira/browse/ASTERISK-22486


Repository: Asterisk


Description
-------

Asterisk does not support any of the transfer encodings specified in
HTTP/1.1, other than the default "identity" encoding.

According to RFC 2616:

   A server which receives an entity-body with a transfer-coding it does
   not understand SHOULD return 501 (Unimplemented), and close the
   connection. A server MUST NOT send transfer-codings to an HTTP/1.0
   client.

This patch adds the 501 Unimplemented response, instead of the hard work
of actually implementing other recordings.

This behavior is especially problematic for Node.js clients, which use
chunked encoding by default.


Diffs (updated)
-----

  /branches/12/main/http.c 404552 

Diff: https://reviewboard.asterisk.org/r/3092/diff/


Testing
-------

HTTP requests using Node.js


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131224/7726d0c9/attachment.html>