[asterisk-dev] [Code Review] 3092: http: Properly reject requests with Transfer-Encoding set

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3092/#review10491
-----------------------------------------------------------



/branches/12/main/http.c
<https://reviewboard.asterisk.org/r/3092/#comment19946>

    Might as well go and make this a generic function to get the value of a header for potential future usage.



/branches/12/main/http.c
<https://reviewboard.asterisk.org/r/3092/#comment19947>

    This is incorrect.


- Joshua Colp


On Dec. 23, 2013, 11:09 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3092/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2013, 11:09 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22486
>     https://issues.asterisk.org/jira/browse/ASTERISK-22486
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Asterisk does not support any of the transfer encodings specified in
> HTTP/1.1, other than the default "identity" encoding.
> 
> According to RFC 2616:
> 
>    A server which receives an entity-body with a transfer-coding it does
>    not understand SHOULD return 501 (Unimplemented), and close the
>    connection. A server MUST NOT send transfer-codings to an HTTP/1.0
>    client.
> 
> This patch adds the 501 Unimplemented response, instead of the hard work
> of actually implementing other recordings.
> 
> This behavior is especially problematic for Node.js clients, which use
> chunked encoding by default.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/http.c 404552 
> 
> Diff: https://reviewboard.asterisk.org/r/3092/diff/
> 
> 
> Testing
> -------
> 
> HTTP requests using Node.js
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131224/59aa2729/attachment.html>