[asterisk-dev] [Code Review] 3088: ari: Remove support for specifying channel vars during origination.

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3088/
-----------------------------------------------------------

(Updated Dec. 20, 2013, 4 p.m.)


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

* Fixed doc
* Actually tested


Bugs: ASTERISK-23051
    https://issues.asterisk.org/jira/browse/ASTERISK-23051


Repository: Asterisk


Description
-------

When we added support for specifying channel variables for an
origination, we didn't consider how that would interact with another
feature, namely specifying request parameters in a JSON request body.

The method of specifying channel variables (as a flat JSON object passed
in the JSON body) interferes with parsing parameters out of the request
body.

Unfortunately, fixing this would be a backward incompatible change. In
the interest of keeping the API sane and keeping our release schedule,
we're dropping the feature for specifying channel variables in the
origination request.

We will bring the feature back soon, as a backward compatible addition
to the API.


Diffs (updated)
-----

  /branches/12/rest-api/api-docs/channels.json 404508 
  /branches/12/rest-api/api-docs/applications.json 404508 
  /branches/12/res/res_ari_channels.c 404508 
  /branches/12/res/ari/resource_channels.c 404508 
  /branches/12/res/ari/resource_channels.h 404508 

Diff: https://reviewboard.asterisk.org/r/3088/diff/


Testing (updated)
-------

Originated a call using a JSON post. Worked as expected.

curl -X POST -H "Content-Type: application/json" -d '{ "endpoint": "SIP/blink", "app": "hello", "timeout": 30 }'  -v 'http://localhost:8088/ari/channels?api_key=ari:ari'


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131220/1cfd13fb/attachment.html>