[asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3061/
-----------------------------------------------------------

(Updated Dec. 20, 2013, 4:29 a.m.)


Review request for Asterisk Developers.


Changes
-------

Updated from review feedback.


Repository: Asterisk


Description (updated)
-------

This patch can be broken into two main components:

1) The core resource support for external MWI providers are in the following files:
apps/app_voicemail.c,
include/asterisk/res_mwi_external.h,
configs/sorcery.conf.sample,
res/res_mwi_external.c, and
res/res_mwi_external.exports.in.

* The core external MWI resource provides for MWI message counts persistence using sorcery.  With sorcery, the user is able to configure which sorcery wizzard backend to use if the default astdb is not desired.

* The core external MWI resoruce provides some debugging CLI commands enabled by defining MWI_DEBUG_CLI.
The debugging CLI commands are:
"mwi delete all",
"mwi delete like <regex>",
"mwi delete mailbox <mailbox>",
"mwi list all",
"mwi list like <regex>",
"mwi show mailbox <mailbox>", and
"mwi update mailbox <mailbox> [<new> [<old>]]".

2) The AMI component of external MWI is in:
res/res_mwi_external_ami.c

* The external MWI AMI interface provides a thin wrapper around the core external MWI resource.
The resource adds the following AMI actions:
MWIGet,
MWIDelete, and
MWIUpdate.


Diffs (updated)
-----

  /trunk/res/res_mwi_external_ami.c PRE-CREATION 
  /trunk/res/res_mwi_external.exports.in PRE-CREATION 
  /trunk/res/res_mwi_external.c PRE-CREATION 
  /trunk/include/asterisk/res_mwi_external.h PRE-CREATION 
  /trunk/configs/sorcery.conf.sample 404401 
  /trunk/apps/app_voicemail.c 404401 

Diff: https://reviewboard.asterisk.org/r/3061/diff/


Testing
-------

Used the CLI "database show" along with the new CLI commands and AMI actions to test adding/updating, getting, and deleting external MWI counts.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131220/2263515c/attachment.html>