[asterisk-dev] [Code Review] 3048: PJSIP: Add T.38 fax tests

Matt Jordan reviewboard at asterisk.org
Tue Dec 17 20:41:27 CST 2013 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3048/#review10446
-----------------------------------------------------------

Ship it!



/asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/test-config.yaml
<https://reviewboard.asterisk.org/r/3048/#comment19910>

    The PJSIP tag is lowercase, i.e.,
      - pjsip
    
    Yes, it is inconsistent. No, I don't know why we did that.
    
    (But at least this way we'll be consistently inconsistent, and that's not nothing)



/asterisk/trunk/tests/fax/pjsip/t38/run-test
<https://reviewboard.asterisk.org/r/3048/#comment19911>

    Blob


- Matt Jordan


On Dec. 11, 2013, 6:33 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3048/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2013, 6:33 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds tests for T.38 faxing using chan_pjsip. Sending and receiving are covered, as is gatewaying.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/fax/voxfax_g711/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/voxfax_g711/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/voxfax_g711/run-test 4410 
>   /asterisk/trunk/tests/fax/voxfax_g711/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/voxfax_g711/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/voxfax_g711/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/voxfax_g711/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/tests.yaml 4410 
>   /asterisk/trunk/tests/fax/sip/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/t38/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/t38/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/pjsip/t38/run-test PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/t38/configs/ast2/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/t38/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/t38/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/t38/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/t38/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/run-test PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/configs/ast2/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/gateway_t38_g711/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/run-test PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/configs/ast2/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/gateway_native_t38/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/sipp/inject_bridge.csv PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/sipp/endpoint_B.xml PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/sipp/endpoint_A.xml PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/pjsip/directmedia_reinvite_t38/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/fax/local_channel_t38_queryoption/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/local_channel_t38_queryoption/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/local_channel_t38_queryoption/run-test 4410 
>   /asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout5/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout5/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/gateway_timeout5/run-test 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout5/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout5/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout5/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout5/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout4/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout4/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/gateway_timeout4/run-test 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout4/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout4/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout4/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout4/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout3/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout3/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/gateway_timeout3/run-test 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout3/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout3/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout3/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout3/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout2/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout2/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/gateway_timeout2/run-test 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout2/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout2/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout2/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout2/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout1/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout1/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/gateway_timeout1/run-test 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout1/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout1/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout1/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_timeout1/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_t38_g711/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/gateway_t38_g711/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/gateway_t38_g711/run-test 4410 
>   /asterisk/trunk/tests/fax/gateway_t38_g711/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_t38_g711/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_t38_g711/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_t38_g711/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_no_t38/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/gateway_no_t38/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/gateway_no_t38/run-test 4410 
>   /asterisk/trunk/tests/fax/gateway_no_t38/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_no_t38/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_no_t38/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_no_t38/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_native_t38_ced/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/gateway_native_t38_ced/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/gateway_native_t38_ced/run-test 4410 
>   /asterisk/trunk/tests/fax/gateway_native_t38_ced/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_native_t38_ced/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_native_t38_ced/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_native_t38_ced/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_native_t38/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/gateway_native_t38/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/gateway_native_t38/run-test 4410 
>   /asterisk/trunk/tests/fax/gateway_native_t38/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_native_t38/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_native_t38/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_native_t38/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix4/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/gateway_mix4/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/gateway_mix4/run-test 4410 
>   /asterisk/trunk/tests/fax/gateway_mix4/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix4/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix4/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix4/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix3/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/gateway_mix3/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/gateway_mix3/run-test 4410 
>   /asterisk/trunk/tests/fax/gateway_mix3/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix3/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix3/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix3/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix2/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/gateway_mix2/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/gateway_mix2/run-test 4410 
>   /asterisk/trunk/tests/fax/gateway_mix2/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix2/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix2/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix2/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix1/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/gateway_mix1/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/gateway_mix1/run-test 4410 
>   /asterisk/trunk/tests/fax/gateway_mix1/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix1/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix1/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_mix1/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_g711_t38/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/gateway_g711_t38/send.tiff UNKNOWN 
>   /asterisk/trunk/tests/fax/gateway_g711_t38/run-test 4410 
>   /asterisk/trunk/tests/fax/gateway_g711_t38/configs/ast2/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_g711_t38/configs/ast2/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_g711_t38/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/gateway_g711_t38/configs/ast1/extensions.conf 4410 
>   /asterisk/trunk/tests/fax/directmedia_reinvite_t38/test-config.yaml 4410 
>   /asterisk/trunk/tests/fax/directmedia_reinvite_t38/sipp/inject_bridge.csv 4410 
>   /asterisk/trunk/tests/fax/directmedia_reinvite_t38/sipp/endpoint_B.xml 4410 
>   /asterisk/trunk/tests/fax/directmedia_reinvite_t38/sipp/endpoint_A.xml 4410 
>   /asterisk/trunk/tests/fax/directmedia_reinvite_t38/configs/ast1/sip.conf 4410 
>   /asterisk/trunk/tests/fax/directmedia_reinvite_t38/configs/ast1/extensions.conf 4410 
> 
> Diff: https://reviewboard.asterisk.org/r/3048/diff/
> 
> 
> Testing
> -------
> 
> Ran tests with framehook patch, all passed. Looked at logs and confirmed happy.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131218/ca6dbb0d/attachment-0001.html>

More information about the asterisk-dev mailing list