[asterisk-dev] [Code Review] 3073: chan_sip+CEL: Add missing ANSWER and PICKUP events to INVITE/w/replaces pickup

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3073/#review10432
-----------------------------------------------------------


I think the order is correct, based on the order of events that should occur in features.c.


/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/3073/#comment19888>

    I think you may only want to raise this if earlyreplace is 1 and oneleggedreplace is 0. Otherwise, this is an attended transfer/one legged transfer (I think, it is chan_sip after all)


- Matt Jordan


On Dec. 16, 2013, 3:26 a.m., wdoekes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3073/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2013, 3:26 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22977
>     https://issues.asterisk.org/jira/browse/ASTERISK-22977
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> To make a long story short:
> 
> - When doing a "BLF-style call pickup" -- an INVITE with Replaces: header -- the CEL log would be missing an ANSWER en PICKUP event.
> 
> - This goes unnoticed when you use Asterisk only, because chan_sip cheats when sending out NOTIFYs. Only when you rely on something else to send out the NOTIFYs (e.g. *SER pua_dialoginfo) does this problem occur.
> 
> This patch adds the two missing events to the handle_invite_replaces() function.
> 
> Long explanation is in the referenced ticket.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 403615 
> 
> Diff: https://reviewboard.asterisk.org/r/3073/diff/
> 
> 
> Testing
> -------
> 
> Tested against 11, but issue is present in 1.8 as well. Test results are reported in ticket. Breaks down to: for my scenario it works, the two missing events are not missing anymore.
> 
> One question: are there other uses of handle_invite_replaces() that should not get these events?
> 
> 
> Thanks,
> 
> wdoekes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131217/187f6657/attachment.html>