[asterisk-dev] [Code Review] 3071: Testsuite: Check CEL Extra fields in an order-agnostic way

Matt Jordan reviewboard at asterisk.org
Fri Dec 13 16:06:54 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3071/#review10414
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Dec. 13, 2013, 12:50 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3071/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2013, 12:50 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22885
>     https://issues.asterisk.org/jira/browse/ASTERISK-22885
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds new functionality to the AMI-based CEL event module to allow checking the CEL Extra field in a way that doesn't depend on arbitrary ordering and thus prevents tests checking this data from bouncing.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/bridge/transfer_failure/test-config.yaml 4437 
>   asterisk/trunk/sample-yaml/ami-config.yaml.sample 4437 
>   asterisk/trunk/lib/python/asterisk/ami.py 4437 
> 
> Diff: https://reviewboard.asterisk.org/r/3071/diff/
> 
> 
> Testing
> -------
> 
> Ensured that the data was being checked properly and that order of appearance did not affect the results of the test.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131213/14505248/attachment.html>


More information about the asterisk-dev mailing list