[asterisk-dev] [Code Review] 2947: ARI: Adding a channel to a bridge while a live recording is active blocks

[Kevin Harwell]

On Dec. 12, 2013, 9:16 a.m., Kevin Harwell wrote:
> > There are other places as well where functions or parameters should return the enum instead of a bare int.

After speaking with opticron it was decided that for now the items mentioned should remain ints and not be changed to an enumeration as the may lead to undesired specifics in the command code.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2947/#review10390
-----------------------------------------------------------


On Nov. 21, 2013, 2:24 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2947/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 2:24 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22624
>     https://issues.asterisk.org/jira/browse/ASTERISK-22624
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added a channel recording flag that is checked before adding a channel to a bridge.  If the the channel is currently being recorded a "409 Conflict" is returned and the channel is not added to the bridge.
> 
> 
> Diffs
> -----
> 
>   branches/12/rest-api/api-docs/bridges.json 402969 
>   branches/12/res/stasis/control.c 402969 
>   branches/12/res/stasis/command.c 402969 
>   branches/12/res/stasis/command.h 402969 
>   branches/12/res/res_stasis_recording.c 402969 
>   branches/12/res/res_stasis_playback.c 402969 
>   branches/12/res/res_stasis_answer.c 402969 
>   branches/12/res/res_ari_bridges.c 402969 
>   branches/12/res/ari/resource_bridges.c 402969 
>   branches/12/include/asterisk/stasis_app_impl.h 402969 
>   branches/12/include/asterisk/stasis_app.h 402969 
> 
> Diff: https://reviewboard.asterisk.org/r/2947/diff/
> 
> 
> Testing
> -------
> 
> Ran a manual test and also wrote a testsuite test: https://reviewboard.asterisk.org/r/2951/
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131212/3c44d92f/attachment.html>