[asterisk-dev] [Code Review] 3063: chan_dahdi: enable ignore_failed_channels by default

[Tzafrir Cohen]

> On Dec. 10, 2013, 5:14 p.m., rmudgett wrote:
> > I don't think changing this default is a good idea.  Enabling it is only useful if you are using the relative channel format.  I have yet to see anyone on the Asterisk users list actually use this format.

ignore_failed_channels was indeed added to support relative channel format. That is: [/dev/dahdi/]<span-name>/<relative-channnel-number>. We originally thought that this was the only way to guarantee stable channel numbers.

However with recent versions of DAHDI we can provide stable channel numbers through other means (/etc/dahdi/span_assignments.conf ). If those are used, DAHDI will assign the requested span and channel numbers for your dahdi devices independenly of any module load order and device discovery. Furthermore, If you only have a single DAHDI device this is a non-issue anyway.

One by-product of this work on hotplug dahdi is that we noticed that we can do away with the DAHDI init script (this still depends on a non-default setting in the DAHDI kernel module, but I hope it will change in the future). And thus Asterisk may start before some or all of the DAHDI devices have been configured. When a device is configured, the hook script responsible for that eventually runs 'asterisk -rx "dahdi create channels <first> <last>"'.

I'm backporting support for this to wherever I can as it solves some real issues I have. Manually configuring chan_dahdi.conf will work, but I prefer to have sane defaults.


- Tzafrir


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3063/#review10359
-----------------------------------------------------------


On Dec. 10, 2013, 4:25 p.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3063/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2013, 4:25 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> If ignore_failed_channels is set to "true" for a channel, the channel will continue to be configured even if configuring it has failed.
> 
> One important this This allows Asterisk to start before all the DAHDI initialization is done and thus not force the starting order dahdi -> asterisk.
> 
> This patch changes the default of the feature from disabled to enabled.
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/chan_dahdi.conf.sample 403615 
>   /trunk/channels/chan_dahdi.c 403615 
> 
> Diff: https://reviewboard.asterisk.org/r/3063/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir Cohen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131210/10c9636c/attachment-0001.html>