[asterisk-dev] [Code Review] 3060: pjsip tests: interactions with chan_sip cause test failures

[Kevin Harwell]

> On Dec. 9, 2013, 2:27 p.m., Mark Michelson wrote:
> > I think this will work well for the testsuite. My only suggestion would be a way to override default conflict behavior if desired. It may be that we wish to write some sort of test where we transfer a call between a chan_sip endpoint and a chan_pjsip endpoint or some such. In such a rare circumstance, it would be a good idea to be able to state that the conflict does not apply for this test.
> > 
> > The other question I have is if you plan to go through the tests that use chan_sip and chan_pjsip and add the appropriate deps to the properties in their test-config.yaml files. Were you holding off on that in case this approach was vetoed?

You mean all the relevant tests don't already have the dependent info specified? ;-)

Yeah I will probably need to go back and add that stuff if the approach seems valid.  Still having to touch a lot of files for the change (potentially), but those files should have the dependency listed anyway and hopefully this approach won't require a test specific module.conf file for all tests (now and future).


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3060/#review10340
-----------------------------------------------------------


On Dec. 9, 2013, 1:54 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3060/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2013, 1:54 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Bugs: ASTERISK-22887
>     https://issues.asterisk.org/jira/browse/ASTERISK-22887
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> While chan_sip and chan_pjsip can be loaded and used at the same time it was causing problems in the testsuite because their defaults try to bind to the same host:port.  So for the testsuite made is so any test that depends on res_pjsip will "noload" chan_sip.  Instead of manipulating every current res_pjsip test (through their own modules.conf or config setting), this fix checks to see if the test requires/depends on res_pjsip and if it does it appends a noload => chan_sip.so to the copied modules.conf for that test.
> 
> This functionality is configured via the newly added conflicts.txt file.  Any new conflicts that may arise hopefully can resuse the mechanism.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/asterisk.py 4415 
>   asterisk/trunk/lib/python/asterisk/TestConfig.py 4415 
>   asterisk/trunk/lib/python/asterisk/TestCase.py 4415 
>   asterisk/trunk/configs/modules.conf PRE-CREATION 
>   asterisk/trunk/configs/conflicts.txt PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/3060/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131209/d6b10208/attachment.html>