[asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3023/
-----------------------------------------------------------

(Updated Dec. 9, 2013, 10:43 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 403512


Repository: Asterisk


Description
-------

This change introduces an 'f' option for the MixMonitor() application. The argument for this option specifies a channel variable into which the application should store the filename (as in, the full path) instead of the standard MIXMONITOR_FILENAME.

The rationale for this option is that MixMonitor is structured in such a way that a single channel may have multiple simultaneous MixMonitors running at any given time. Thus, the MixMonitor application should not have any assumptions that the channel has only a single MixMonitor being run on it. Setting a single MIXMONITOR_FILENAME channel variable violates such assumptions by overwriting the value set from previous invocations of MixMonitor. By using the 'f' and 'i' options for MixMonitor, a user can easily manage multiple recordings on a single channel.


Diffs
-----

  /trunk/apps/app_mixmonitor.c 402883 

Diff: https://reviewboard.asterisk.org/r/3023/diff/


Testing
-------

See https://reviewboard.asterisk.org/r/3024/


Thanks,

Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131209/84f10254/attachment.html>