[asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3046/
-----------------------------------------------------------

(Updated Dec. 9, 2013, 1:27 a.m.)


Review request for Asterisk Developers.


Changes
-------

Incorporated feedback from Matt.

Re: Comment about looking at framehook implementations. They all seem to do just what they need to do, and return as rapidly as possible.


Repository: Asterisk


Description
-------

Currently when a frame is changed by a frame hook previous hooks aren't aware of it. This can be a problem when a previous hook reacts to the types of frames that a subsequent hook produces. An example of this would be the fax gateway hook and the PJSIP T.38 hook. Since the fax gateway hook injects T.38 control frames after the T.38 hook, nothing happens.

The attached change makes it so if a frame hook produces a different frame the hook iteration loop is restarted, skipping the hook that has produced the frame.


Diffs (updated)
-----

  /branches/12/main/framehook.c 403448 

Diff: https://reviewboard.asterisk.org/r/3046/diff/


Testing
-------

Ran fax tests, confirmed fixed.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131209/6b867c9a/attachment.html>