[asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3053/#review10321
-----------------------------------------------------------


On the one hand, using AppTest for this set of tests seems like an overly-complicated approach to use, but on the other hand, it works, so it's fine by me.

Only reason I'm not putting a "Ship it!" on this review is that I want to be sure that the old page test hasn't been outright removed but just moved somewhere. It may be a quirk of review board or you may have purposely not included the old test since it is not relevant, but since it's not here I just wanted to make sure it hadn't disappeared.

- Mark Michelson


On Dec. 5, 2013, 11:36 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3053/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2013, 11:36 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, opticron, and rmudgett.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Pretty straightforward. Tests that predial handlers are applied on the appropriate channels when app_page uses the predial options. See the test yaml for a slightly more in depth description.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/tests.yaml 4397 
>   /asterisk/trunk/tests/apps/page/test-config.yaml 4397 
>   /asterisk/trunk/tests/apps/page/run-test 4397 
>   /asterisk/trunk/tests/apps/page/page_predial/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/apps/page/page_predial/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/apps/page/configs/ast1/iax.conf 4397 
>   /asterisk/trunk/tests/apps/page/configs/ast1/extensions.conf 4397 
>   /asterisk/trunk/tests/apps/page/configs/ast1/amd.conf 4397 
> 
> Diff: https://reviewboard.asterisk.org/r/3053/diff/
> 
> 
> Testing
> -------
> 
> It runs and it doesn't fail with the patch applied.  It does without the patch applied.  I checked through logs to make sure channels hit everything in the PBX as expected.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131206/570e06f9/attachment.html>