[asterisk-dev] [Code Review] 3045: app_page: Add predial handlers

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3045/#review10320
-----------------------------------------------------------

Ship it!



/trunk/main/dial.c
<https://reviewboard.asterisk.org/r/3045/#comment19721>

    Check for a NULL return here. This will go badly if app_stack.so is not loaded.


- Mark Michelson


On Dec. 5, 2013, midnight, Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3045/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2013, midnight)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and rmudgett.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds predial handlers to app_page. This required some modifications to the dial API to allow for that.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/dial.c 403361 
>   /trunk/include/asterisk/dial.h 403361 
>   /trunk/apps/app_page.c 403361 
>   /trunk/CHANGES 403361 
> 
> Diff: https://reviewboard.asterisk.org/r/3045/diff/
> 
> 
> Testing
> -------
> 
> Called Page with b and B options to make sure the correct gosubs were ran on the correct channels for one and two channel request strings.
> 
> Called Page without options to make sure the normal behavior remained... normal.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131206/d777b51e/attachment-0001.html>