[asterisk-dev] [Code Review] 3043: pjsip: CLI commands

[Jonathan Rose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3043/#review10308
-----------------------------------------------------------



branches/12/include/asterisk/res_pjsip.h
<https://reviewboard.asterisk.org/r/3043/#comment19700>

    You just need one line of white space here.



branches/12/main/config.c
<https://reviewboard.asterisk.org/r/3043/#comment19699>

    You just need one line of white space between functions



branches/12/res/res_pjsip/pjsip_configuration.c
<https://reviewboard.asterisk.org/r/3043/#comment19695>

    Don't mix tabs and spaces when doing this kind of alignment.



branches/12/res/res_pjsip_endpoint_identifier_ip.c
<https://reviewboard.asterisk.org/r/3043/#comment19698>

    I think you forgot to include the new files that go with this in the review. If you don't 'svn add' them, they won't get included in the diff.



branches/12/res/res_pjsip_endpoint_identifier_ip.c
<https://reviewboard.asterisk.org/r/3043/#comment19701>

    You only need one line of white space here.


I wanted to give this a test run before getting too into depth on this, but it won't compile without the missing files.

- Jonathan Rose


On Dec. 4, 2013, 10:42 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3043/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2013, 10:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22610
>     https://issues.asterisk.org/jira/browse/ASTERISK-22610
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Implements the following cli commands:
> pjsip list aors
> pjsip list auths
> pjsip list channels
> pjsip list contacts
> pjsip list endpoints
> pjsip show aor(s)
> pjsip show auth(s)
> pjsip show channels
> pjsip show endpoint(s)
> 
> Also...
> Minor modifications made to the AMI command implementations to facilitate reuse.
> New function ast_variable_list_sort added to config.c and config.h to implement variable list sorting.
> New api ast_sip_for_each_identify added to module res_pjsip_endpoint_identifier_ip. Required new files res_pjsip_endpoint_identifier_ip.h and res_pjsip_endpoint_identifier_ip.exports.in.
> 
> Implementation of the summary statistics is still pending.
> I'm sure there will be lots of feedback here. :)
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_registrar.c 403390 
>   branches/12/res/res_pjsip_endpoint_identifier_ip.c 403390 
>   branches/12/res/res_pjsip/pjsip_configuration.c 403390 
>   branches/12/res/res_pjsip/location.c 403390 
>   branches/12/res/res_pjsip/include/res_pjsip_private.h 403390 
>   branches/12/main/config.c 403390 
>   branches/12/include/asterisk/res_pjsip.h 403390 
>   branches/12/include/asterisk/config.h 403390 
> 
> Diff: https://reviewboard.asterisk.org/r/3043/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131205/e5e30606/attachment-0001.html>