[asterisk-dev] [Code Review] 3041: app_record: Add an option that allows DTMF '0' to act as an additional terminator

Mark Michelson reviewboard at asterisk.org
Wed Dec 4 14:02:13 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3041/#review10298
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On Dec. 3, 2013, 11:04 p.m., Jonathan Rose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3041/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 11:04 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and rmudgett.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> If the option is in use and '0' is used to exit the application, ${RECORD_STATUS} will also be set to 'OPERATOR' instead of 'DTMF'.
> Pretty straight forward.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_record.c 403345 
> 
> Diff: https://reviewboard.asterisk.org/r/3041/diff/
> 
> 
> Testing
> -------
> 
> Tested with and without 'o' option to make sure normal exit DTMF still resulted in exiting with 'DTMF' for ${RECORD_STATUS}
> Tested that the 'o' option made '0' DTMF result in 'OPERATOR' for ${RECORD_STATUS}. Also that this takes precedence when using the any terminator option.
> 
> 
> Thanks,
> 
> Jonathan Rose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131204/e41bb23f/attachment.html>


More information about the asterisk-dev mailing list