[asterisk-dev] [Code Review] 2806: features_config: No longer require the presence of features.conf to load Asterisk

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2806/#review9570
-----------------------------------------------------------



/branches/12/main/features_config.c
<https://reviewboard.asterisk.org/r/2806/#comment18756>

    initialzie => initialize



/branches/12/main/features_config.c
<https://reviewboard.asterisk.org/r/2806/#comment18757>

    Pedantic: don't capitalize after a semi-colon.
    
    Also, this is not a WARNING. The features config is not required. This should be a NOTICE.



/branches/12/main/udptl.c
<https://reviewboard.asterisk.org/r/2806/#comment18758>

    Same comment here about this being a NOTICE.


- Matt Jordan


On Aug. 29, 2013, 4:34 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2806/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 4:34 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and Mark Michelson.
> 
> 
> Bugs: ASTERISK-22426
>     https://issues.asterisk.org/jira/browse/ASTERISK-22426
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Similar to https://reviewboard.asterisk.org/r/2773/ - Asterisk would fail to load if features.conf wasn't present. This patch changes it so that on the initial load, if these files aren't present then we'll simply use the default options for the general options and the featuremap.
> 
> I've also updated the UDPTL method for doing this to match the way I'm doing it here, which I feel is cleaner and more verbose in the event of failure.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/features_config.c 397920 
>   /branches/12/main/udptl.c 397920 
> 
> Diff: https://reviewboard.asterisk.org/r/2806/diff/
> 
> 
> Testing
> -------
> 
> Basically the same thing as with udptl. I tried to load unpatched without a config and failed to load Asterisk entirely. After the patch, the output for 'features show' is as follows:
> 
> *CLI> features show 
> Builtin Feature           Default Current
> ---------------           ------- -------
> Pickup                    *8      *8     
> Blind Transfer            #       #      
> Attended Transfer                        
> One Touch Monitor                        
> Disconnect Call           *       *      
> Park Call                                
> One Touch MixMonitor                     
> 
> Dynamic Feature           Default Current
> ---------------           ------- -------
> (none)
> 
> Feature Groups:
> ---------------
> (none)
> 
> Reloads are rejected if no features.conf is provided at reload still and the current options will remain in tact (it won't attempt to use the default options if you remove it after having options already in place).
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130830/a0323f30/attachment.htm>