[asterisk-dev] [Code Review] 2804: Fix Segfault In features-config.c When Processing features.conf And Application Doesn't Have Arguments

[Mark Michelson]

> On Aug. 29, 2013, 7:52 a.m., wdoekes wrote:
> > /trunk/main/features_config.c, lines 1354-1356
> > <https://reviewboard.asterisk.org/r/2804/diff/1/?file=45328#file45328line1354>
> >
> >     Perhaps you'd better set app_data to "" if it's NULL.
> >     
> >     Below it gets printed by an ast_debug(), and some *printf implementations can't cope with NULL for "%s".

Agreed. Otherwise, ship it!


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2804/#review9558
-----------------------------------------------------------


On Aug. 29, 2013, 4:51 a.m., Michael Young wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2804/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 4:51 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Came across this segfault on a virtual machine that had some application maps where they were calling MusicOnHold without any arguments.
> 
> Created this patch to check if the arguments for the application are present.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/features_config.c 397908 
> 
> Diff: https://reviewboard.asterisk.org/r/2804/diff/
> 
> 
> Testing
> -------
> 
> Tested on Dev VM
> 
> 
> Thanks,
> 
> Michael Young
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130830/3d0bef81/attachment.htm>