[asterisk-dev] [Code Review] 2693: ARI: Implement /recordings/stored API's

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2693/#review9561
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Aug. 29, 2013, 4:31 a.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2693/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 4:31 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21582
>     https://issues.asterisk.org/jira/browse/ASTERISK-21582
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch implements the ARI API's for stored recordings. While the
> original task only specified deleting a recording, it was simple
> enough to implement the GET for all recordings, and for an individual
> recording.
> 
> The recording playback operation was modified to use the same code for
> accessing the recording as the REST API, so that they will behave
> consistently.
> 
> There were several problems with the api-docs that were also fixed,
> bringing the ARI spec in line with the implementation. There were some
> 'wishful thinking' fields on the stored recording model (duration and
> timestamp) that were removed, because I ended up not implementing a
> metadata file to go along with the recording to store such information.
> 
> The GET /recordings/live operation was removed, since it's not really
> that useful to get a list of all recordings that are currently going
> on in the system. (At least, if we did that, we'd probably want to
> also list all of the current playbacks. Which seems weird.)
> 
> 
> Diffs
> -----
> 
>   /branches/12/include/asterisk/stasis_app_recording.h 397908 
>   /branches/12/res/Makefile 397908 
>   /branches/12/res/ari/ari_model_validators.h 397908 
>   /branches/12/res/ari/ari_model_validators.c 397908 
>   /branches/12/res/ari/resource_recordings.h 397908 
>   /branches/12/res/ari/resource_recordings.c 397908 
>   /branches/12/res/res_ari_recordings.c 397908 
>   /branches/12/res/res_stasis_playback.c 397908 
>   /branches/12/res/res_stasis_recording.c 397908 
>   /branches/12/res/stasis_recording/stored.c PRE-CREATION 
>   /branches/12/rest-api/api-docs/recordings.json 397908 
> 
> Diff: https://reviewboard.asterisk.org/r/2693/diff/
> 
> 
> Testing
> -------
> 
> Used Swagger-UI to poke around the API. Verified that you couldn't
> delete anything outside the recording's directory.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130829/73ff660c/attachment.htm>