[asterisk-dev] [Code Review] 2801: feature_config: Read and ignore parkinglots

[jrose]

> On Aug. 28, 2013, 10:18 p.m., Matt Jordan wrote:
> > /branches/12/main/features_config.c, lines 1847-1849
> > <https://reviewboard.asterisk.org/r/2801/diff/1/?file=45276#file45276line1847>
> >
> >     Why is this, and all of the parking lot object code, even needed? This should just warn the user that parking lots aren't defined here any more and move on.
> >     
> >     You should be able to just call unsupported_handler.
> 
> jrose wrote:
>     There has to be an object for the parking lot object type to match on. If there isn't, the category will be read, no objects will match it, and the whole configuration will be seen as invalid. unsupported_handler only works on config options within a category.
> 
> Mark Michelson wrote:
>     My question is, why have an ACO_ITEM aco_type defined for parking? If the config framework needs to find something, just define an ACO_GLOBAL type that returns some dummy field for all parking lot definitions. That way you don't need item_alloc and item_find callbacks. Then the unsupported_handler can report the problems when the individual items are encountered.

Yeah, I think that's probably the approach I should be taking now that I've spent a little time probing at it.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2801/#review9547
-----------------------------------------------------------


On Aug. 28, 2013, 10:03 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2801/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 10:03 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore, Matt Jordan, and Mark Michelson.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Presence of a parkinglot in features.conf will currently cause Asterisk to fail to load due to the presence of an unrecognized configuration option. That's less than ideal and it makes having configurations across multiple versions of Asterisk difficult (which has impacted an automated parking test). This patch addresses that by reading in parkinglots and issuing a warning as they are created telling the user that parkinglots should no longer be configured in this module.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/config_options.c 397880 
>   /branches/12/main/features_config.c 397880 
> 
> Diff: https://reviewboard.asterisk.org/r/2801/diff/
> 
> 
> Testing
> -------
> 
> Tested loads and reloads with difference in the number and properties of parkinglots. Tested to make sure there was no impact on memory usage once the loads/reloads were finished.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130828/118bed3c/attachment.htm>