[asterisk-dev] [Code Review] 2801: feature_config: Read and ignore parkinglots

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2801/#review9547
-----------------------------------------------------------



/branches/12/main/features_config.c
<https://reviewboard.asterisk.org/r/2801/#comment18663>

    Why is this, and all of the parking lot object code, even needed? This should just warn the user that parking lots aren't defined here any more and move on.
    
    You should be able to just call unsupported_handler.


- Matt Jordan


On Aug. 28, 2013, 10:03 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2801/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 10:03 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore, Matt Jordan, and Mark Michelson.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Presence of a parkinglot in features.conf will currently cause Asterisk to fail to load due to the presence of an unrecognized configuration option. That's less than ideal and it makes having configurations across multiple versions of Asterisk difficult (which has impacted an automated parking test). This patch addresses that by reading in parkinglots and issuing a warning as they are created telling the user that parkinglots should no longer be configured in this module.
> 
> 
> Diffs
> -----
> 
>   /branches/12/main/config_options.c 397880 
>   /branches/12/main/features_config.c 397880 
> 
> Diff: https://reviewboard.asterisk.org/r/2801/diff/
> 
> 
> Testing
> -------
> 
> Tested loads and reloads with difference in the number and properties of parkinglots. Tested to make sure there was no impact on memory usage once the loads/reloads were finished.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130828/5ef97c6d/attachment.htm>