[asterisk-dev] [Code Review] 2789: testsuite: Fix fastagi/control-stream-file for Asterisk 12

svnbot reviewboard at asterisk.org
Tue Aug 27 13:26:42 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2789/
-----------------------------------------------------------

(Updated Aug. 27, 2013, 1:26 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

Committed in revision 4086


Bugs: ASTERISK-22322
    https://issues.asterisk.org/jira/browse/ASTERISK-22322


Repository: testsuite


Description
-------

Asterisk 12 changes the response of AGI 'control stream file' to include
the endpos of where the playback stopped.

StarPy [has a patch][1] to take this into account. This patch corrects
the corresponding test in the TestSuite.

In addition to fixing the test:
 * print statements were replaced with logging
 * clarified the logic for handling the response to controlStreamFile().

 [1]: https://github.com/asterisk/starpy/pull/23


Diffs
-----

  /asterisk/trunk/tests/fastagi/control-stream-file/run-test 4062 

Diff: https://reviewboard.asterisk.org/r/2789/diff/


Testing
-------

Test passes for Asterisk 1.8 and 12.


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130827/7caece17/attachment.htm>


More information about the asterisk-dev mailing list