[asterisk-dev] [Code Review] 2795: Update CHANGES file for Asterisk 12

[Matt Jordan]

> On Aug. 26, 2013, 4:03 p.m., Mark Michelson wrote:
> > /branches/12/CHANGES, lines 128-130
> > <https://reviewboard.asterisk.org/r/2795/diff/1/?file=45151#file45151line128>
> >
> >     either
> >     
> >     s/bridge,/bridge and/
> >     
> >     or
> >     
> >     s/bridge, optionally entertains them/bridge, optionally entertaining them/
> >     
> >     It looks like this sentence may have originally had more to it and was not edited properly when the extra content was removed.

"Optionally entertaining them"


> On Aug. 26, 2013, 4:03 p.m., Mark Michelson wrote:
> > /branches/12/CHANGES, lines 361-363
> > <https://reviewboard.asterisk.org/r/2795/diff/1/?file=45151#file45151line361>
> >
> >     So "blonde" transfer is one of those terms that is used internally but otherwise is an unknown concept to most people. I think a mention of it in CHANGES will confuse more than it helps.

Removed


> On Aug. 26, 2013, 4:03 p.m., Mark Michelson wrote:
> > /branches/12/CHANGES, lines 719-726
> > <https://reviewboard.asterisk.org/r/2795/diff/1/?file=45151#file45151line719>
> >
> >     It's worth noting that the DTMF combinations for the attended transfer actions are configurable in features.conf. The options are:
> >     
> >     atxferabort
> >     atxfercomplete
> >     atxferthreeway
> >     atxferswap
> >     
> >     The DTMF sequences you have listed are the defaults.
> >     
> >     Also, in the description for *4,
> >     s/this options/this option/

Those options aren't listed in the sample config :-)

(Although I'm sure they are in the CLI help, people, including myself, aren't quite used to looking there yet)


> On Aug. 26, 2013, 4:03 p.m., Mark Michelson wrote:
> > /branches/12/CHANGES, line 946
> > <https://reviewboard.asterisk.org/r/2795/diff/1/?file=45151#file45151line946>
> >
> >     "pjproject" should be capitalized properly. I'm not sure if it's officially "PJPROJECT" or "PJProject"
> >     
> >     So maybe instead of "pjpoject SIP stack" just say "PJSIP" ?

It is typically referred to as PJSIP on the website; PJSIP it is.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2795/#review9519
-----------------------------------------------------------


On Aug. 25, 2013, 2:51 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2795/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2013, 2:51 p.m.)
> 
> 
> Review request for Asterisk Developers, David Lee, Joshua Colp, jrose, Mark Michelson, opticron, and rmudgett.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> I went through a diff of all changes from 11 to 12 and updates the CHANGES file with things I think we missed.
> 
> Is there anything else we missed not in this review or in the file?
> 
> I'll update the UPGRADE.txt file based on the information in this review.
> 
> 
> Diffs
> -----
> 
>   /branches/12/CHANGES 397627 
> 
> Diff: https://reviewboard.asterisk.org/r/2795/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130827/50442702/attachment-0001.htm>