[asterisk-dev] [Code Review] 2795: Update CHANGES file for Asterisk 12

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2795/#review9519
-----------------------------------------------------------



/branches/12/CHANGES
<https://reviewboard.asterisk.org/r/2795/#comment18624>

    The last sentence of this item should get its own bullet point.



/branches/12/CHANGES
<https://reviewboard.asterisk.org/r/2795/#comment18625>

    either
    
    s/bridge,/bridge and/
    
    or
    
    s/bridge, optionally entertains them/bridge, optionally entertaining them/
    
    It looks like this sentence may have originally had more to it and was not edited properly when the extra content was removed.



/branches/12/CHANGES
<https://reviewboard.asterisk.org/r/2795/#comment18626>

    s/do no/do not/



/branches/12/CHANGES
<https://reviewboard.asterisk.org/r/2795/#comment18627>

    UserEvent was always distributed to AMI, so I'd remove its mention in this bullet point. Or reword it to say something like
    
    "In addition to AMI, UserEvent invocations will now be distributed to any interested Stasis applications"



/branches/12/CHANGES
<https://reviewboard.asterisk.org/r/2795/#comment18628>

    So "blonde" transfer is one of those terms that is used internally but otherwise is an unknown concept to most people. I think a mention of it in CHANGES will confuse more than it helps.



/branches/12/CHANGES
<https://reviewboard.asterisk.org/r/2795/#comment18629>

    It's worth noting that the DTMF combinations for the attended transfer actions are configurable in features.conf. The options are:
    
    atxferabort
    atxfercomplete
    atxferthreeway
    atxferswap
    
    The DTMF sequences you have listed are the defaults.
    
    Also, in the description for *4,
    s/this options/this option/



/branches/12/CHANGES
<https://reviewboard.asterisk.org/r/2795/#comment18630>

    "pjproject" should be capitalized properly. I'm not sure if it's officially "PJPROJECT" or "PJProject"
    
    So maybe instead of "pjpoject SIP stack" just say "PJSIP" ?



/branches/12/CHANGES
<https://reviewboard.asterisk.org/r/2795/#comment18631>

    I suggest giving an example of what a "parseable Goto string" is here.



/branches/12/CHANGES
<https://reviewboard.asterisk.org/r/2795/#comment18632>

    It's just pjsip.conf, not res_pjsip.conf



/branches/12/CHANGES
<https://reviewboard.asterisk.org/r/2795/#comment18633>

    s/res_pjsip.conf/pjsip.conf/


- Mark Michelson


On Aug. 25, 2013, 2:51 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2795/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2013, 2:51 p.m.)
> 
> 
> Review request for Asterisk Developers, David Lee, Joshua Colp, jrose, Mark Michelson, opticron, and rmudgett.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> I went through a diff of all changes from 11 to 12 and updates the CHANGES file with things I think we missed.
> 
> Is there anything else we missed not in this review or in the file?
> 
> I'll update the UPGRADE.txt file based on the information in this review.
> 
> 
> Diffs
> -----
> 
>   /branches/12/CHANGES 397627 
> 
> Diff: https://reviewboard.asterisk.org/r/2795/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130826/254b430c/attachment-0001.htm>