[asterisk-dev] [Code Review] 2790: Create test events necessary for bridging tests to pass

[Mark Michelson]

> On Aug. 23, 2013, 8:48 p.m., rmudgett wrote:
> > /trunk/main/bridge_channel.c, lines 1211-1217
> > <https://reviewboard.asterisk.org/r/2790/diff/2/?file=44473#file44473line1211>
> >
> >     This is an odd change considering the only thing you really did was insert the test line.
> 
> Mark Michelson wrote:
>     I don't understand what which part of the change is odd.

I'm going ahead and committing. I can revert whatever is odd after the commit goes in.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2790/#review9514
-----------------------------------------------------------


On Aug. 23, 2013, 8:15 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2790/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2013, 8:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: AST-1200
>     https://issues.asterisk.org/jira/browse/AST-1200
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Kinsey already modified the bridge test object in the test suite to be able to handle the new bridging events that trunk has.
> 
> This set of changes adds the FEATURE_DETECTION events into the bridging framework so that bridge tests can operate properly.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/bridge_channel.c 397583 
> 
> Diff: https://reviewboard.asterisk.org/r/2790/diff/
> 
> 
> Testing
> -------
> 
> I used the disconnect test as the basis to see if bridge test object can function properly. The disconnect test passes the actual bridging portion. The test fails, however, when it attempts to see if the CEL records match the expected output.
> 
> There are, however, individual tasks currently assigned to people to get the individual tests running properly, so items such as CEL mismatches will be handled in those tasks.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130823/51ed796f/attachment-0001.htm>