[asterisk-dev] [Code Review] 2715: Bucket: A generic file and directory API

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2715/
-----------------------------------------------------------

(Updated Aug. 23, 2013, 8:17 p.m.)


Review request for Asterisk Developers.


Changes
-------

Made uriparser optional. If present it is used, otherwise some simple logic which gets only the scheme is used.


Repository: Asterisk


Description
-------

Bucket is a generic file and directory API implemented as a thin wrapper over sorcery. It decouples the storage of files from the backend and provides the ability to set metadata on file themselves. What it means to have files in a "bucket" and details about the files themselves is left up to the user of the bucket API. It enforces no restrictions. Identification of things is done using URIs, which include a scheme. Modules implement specific schemes (local, for example) and take care of the implementation specific aspect of it. The ability to get bucket and file information in a JSON format is provided, as is the ability to copy and move files.

Stuff to focus on:

1. Is the API sane and complete?
2. Do the unit tests cover everything?
3. What do we want to do for URI parsing - I wrote a basic extremely optimistic one


Diffs (updated)
-----

  /trunk/build_tools/menuselect-deps.in 397583 
  /trunk/configure UNKNOWN 
  /trunk/configure.ac 397583 
  /trunk/include/asterisk/autoconfig.h.in 397583 
  /trunk/include/asterisk/bucket.h PRE-CREATION 
  /trunk/include/asterisk/config_options.h 397583 
  /trunk/main/Makefile 397583 
  /trunk/main/asterisk.c 397583 
  /trunk/main/bucket.c PRE-CREATION 
  /trunk/main/config_options.c 397583 
  /trunk/main/sorcery.c 397583 
  /trunk/makeopts.in 397583 
  /trunk/tests/test_bucket.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/2715/diff/


Testing
-------

Ran unit tests, confirmed functional. Tweaked this to purposely break and confirmed they broke.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130823/c5b0c95d/attachment.htm>