[asterisk-dev] [Code Review] 2792: Make the failing Queue tests pass

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2792/#review9507
-----------------------------------------------------------



/asterisk/trunk/tests/apps/queues/position_priority_maxlen/run-test
<https://reviewboard.asterisk.org/r/2792/#comment18595>

    The defer import is unnecessary.



/asterisk/trunk/tests/apps/queues/position_priority_maxlen/run-test
<https://reviewboard.asterisk.org/r/2792/#comment18593>

    This is unnecessary.



/asterisk/trunk/tests/apps/queues/position_priority_maxlen/run-test
<https://reviewboard.asterisk.org/r/2792/#comment18592>

    This is unnecessary.


You may want to hit the converted test with pylint (for pep8ness) as well since it's essentially a brand new file.

- opticron


On Aug. 23, 2013, 9:12 a.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2792/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2013, 9:12 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22315
>     https://issues.asterisk.org/jira/browse/ASTERISK-22315
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> The queue_baseline, set_penalty, and position_priority_maxlen tests were failing with Asterisk 12. In each case, the reason was that the tests had not been modified to take into account the new names of manager events or the new names of manager event headers. The queue_baseline and set_penalty tests have small modifications to make them pass.
> 
> The position_priority_maxlen test, on the other hand, has been converted from lua to python. This wasn't necessary to get the test to pass, but the test now runs in ~15 seconds instead of ~80 seconds. The lua script had difficulty terminating Asterisk once the test actually completed, so the test would run until the test timeout was reached. The python test library shuts Asterisk down more quickly once the test cases are complete, and so the test ends much more quickly.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/apps/queues/position_priority_maxlen/configs/ast1/extensions.conf 3966 
>   /asterisk/trunk/tests/apps/queues/position_priority_maxlen/run-test 3966 
>   /asterisk/trunk/tests/apps/queues/position_priority_maxlen/test.lua 3966 
>   /asterisk/trunk/tests/apps/queues/queue_baseline/run-test 3966 
>   /asterisk/trunk/tests/apps/queues/set_penalty/run-test 3966 
> 
> Diff: https://reviewboard.asterisk.org/r/2792/diff/
> 
> 
> Testing
> -------
> 
> I ran the three tests against both Asterisk 11 and Asterisk 12 after making the changes. Tests pass on both versions of Asterisk.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130823/bf0af77e/attachment.htm>