[asterisk-dev] [Code Review] 2790: Create test events necessary for bridging tests to pass

[opticron]

> On Aug. 22, 2013, 2:41 p.m., Matt Jordan wrote:
> > /trunk/main/bridge_channel.c, line 1155
> > <https://reviewboard.asterisk.org/r/2790/diff/1/?file=44401#file44401line1155>
> >
> >     Why do we still need this event?
> >     
> >     If we have a 'feature detection' event, then can't the tests just look for that event and fail if they don't get it?

It is possible to wait for the absence of an event, but the failure indication significantly reduces test duration by allowing the test to avoid relying on a timeout. Looking through the testsuite, about 40% of the feature checks specify that the feature attempt should fail.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2790/#review9491
-----------------------------------------------------------


On Aug. 22, 2013, 11:38 a.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2790/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 11:38 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: AST-1200
>     https://issues.asterisk.org/jira/browse/AST-1200
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Kinsey already modified the bridge test object in the test suite to be able to handle the new bridging events that trunk has.
> 
> This set of changes adds the FEATURE_DETECTION events into the bridging framework so that bridge tests can operate properly.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/bridge_channel.c 397345 
> 
> Diff: https://reviewboard.asterisk.org/r/2790/diff/
> 
> 
> Testing
> -------
> 
> I used the disconnect test as the basis to see if bridge test object can function properly. The disconnect test passes the actual bridging portion. The test fails, however, when it attempts to see if the CEL records match the expected output.
> 
> There are, however, individual tasks currently assigned to people to get the individual tests running properly, so items such as CEL mismatches will be handled in those tasks.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130823/ef082d11/attachment.htm>