[asterisk-dev] [Code Review] 2725: Allow SayAlpha to announce "Uppercase <letter>" in a string

Mark Michelson reviewboard at asterisk.org
Thu Aug 22 13:07:46 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2725/#review9486
-----------------------------------------------------------

Ship it!


As Matt suggested in his previous review, be sure to update CHANGES.

- Mark Michelson


On Aug. 22, 2013, 5:08 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2725/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 5:08 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-20782
>     https://issues.asterisk.org/jira/browse/ASTERISK-20782
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> I'm posting this patch for Kevin Scott Adams from issue ASTERISK-20782 (with very minor cleanup and porting to trunk).
> 
> From the issue:
> The application SayAlpha currently does not allow for the announcement of "Uppercase" letters in the string.
> The example we came across is in our IVR that allows users to reset their password. When the password is auto-generated by the back-end system the security policy specs that the password must have Upper case letter(s) in the password, leading to the Asterisk system to just announce letters.
> This patch is a quick and dirty way to get Uppercase to be announced (e.q. - "g Uppercase h n b Uppercase y").
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_chanspy.c 397430 
>   /trunk/apps/app_directory.c 397430 
>   /trunk/apps/app_voicemail.c 397430 
>   /trunk/include/asterisk/say.h 397430 
>   /trunk/main/channel.c 397430 
>   /trunk/main/pbx.c 397430 
>   /trunk/main/say.c 397430 
>   /trunk/res/res_agi.c 397430 
> 
> Diff: https://reviewboard.asterisk.org/r/2725/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130822/fc23feae/attachment.htm>


More information about the asterisk-dev mailing list