[asterisk-dev] [Code Review] 2778: Fix memory corruption when trying to get "core show locks".

[rmudgett]

> On Aug. 22, 2013, 7:08 a.m., wdoekes wrote:
> > /branches/1.8/include/asterisk/astmm.h, lines 57-59
> > <https://reviewboard.asterisk.org/r/2778/diff/1/?file=44304#file44304line57>
> >
> >     I'd prefer a different infix than _real_. The other allocs and frees are real too.
> >     
> >     Suggestions: _std_, _normal_, _vanilla_, _nodbg_

I think _std_ is the best in this case.


> On Aug. 22, 2013, 7:08 a.m., wdoekes wrote:
> > /branches/1.8/include/asterisk/astmm.h, lines 57-59
> > <https://reviewboard.asterisk.org/r/2778/diff/1/?file=44304#file44304line57>
> >
> >     Missing ast_real_realloc ?

Definitely missing.  Since I don't have BETTER_BACKTRACES installed on my machines, I didn't get the compiler error about it.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2778/#review9467
-----------------------------------------------------------


On Aug. 21, 2013, 6:09 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2778/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2013, 6:09 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22221
>     https://issues.asterisk.org/jira/browse/ASTERISK-22221
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Review https://reviewboard.asterisk.org/r/2580/ tried to fix the mismatch in memory pools but had a math error determining the buffer size and didn't address other similar memory pool mismatches.
> 
> * Effectively reverted the previous patch to go in the same direction as trunk for the returned memory pool of ast_bt_get_symbols().
> 
> * Fixed memory leak in ast_bt_get_symbols() when BETTER_BACKTRACES is defined.
> 
> * Fixed some formatting in ast_bt_get_symbols().
> 
> * Fixed sig_pri.c freeing memory allocated by libpri when MALLOC_DEBUG is enabled.
> 
> * Fixed __dump_backtrace() freeing memory from ast_bt_get_symbols() when MALLOC_DEBUG is enabled.
> 
> * Moved __dump_backtrace() because of compile issues with the utils directory.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/sig_pri.c 397345 
>   /branches/1.8/include/asterisk/astmm.h 397345 
>   /branches/1.8/include/asterisk/lock.h 397345 
>   /branches/1.8/include/asterisk/logger.h 397345 
>   /branches/1.8/include/asterisk/utils.h 397345 
>   /branches/1.8/main/astmm.c 397345 
>   /branches/1.8/main/astobj2.c 397345 
>   /branches/1.8/main/lock.c 397345 
>   /branches/1.8/main/logger.c 397345 
>   /branches/1.8/main/utils.c 397345 
> 
> Diff: https://reviewboard.asterisk.org/r/2778/diff/
> 
> 
> Testing
> -------
> 
> * Ran the testsuite masquerade test and it no longer fails/crashes.
> 
> * Did a manual local channel chain optimization with another console doing a "core show locks".  The other console did not cause a crash when the "core show locks" showed some lock backtraces.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130822/4577dc5d/attachment.htm>