[asterisk-dev] [Code Review] 2773: UDPTL: Allow UDPTL to use default configurations when no udptl.conf is present

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2773/#review9449
-----------------------------------------------------------

Ship it!


Ah, the bug report mentions this:

> UDPTL fails to initialize configurations when udptl.conf isn't
> present. Since this configuration wasn't necessary prior to
> Asterisk 11 and doesn't pertain to new functionality, Asterisk
> should use default options for this component when the
> configuration file is unavailanle.

The fact that it's a regression from 1.8 is pertinent info.


/branches/11/main/udptl.c
<https://reviewboard.asterisk.org/r/2773/#comment18531>

    Note that we now don't get notified when "the configuration is not updated/reloaded because no udptl.conf could be read".
    
    But 1.8 was even less verbose.


- wdoekes


On Aug. 20, 2013, 9:22 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2773/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2013, 9:22 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore, Matt Jordan, and Mark Michelson.
> 
> 
> Bugs: ASTERISK-22349
>     https://issues.asterisk.org/jira/browse/ASTERISK-22349
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> If UDPTL failed to load properly due to lack of a configuration file, Asterisk would log a failure to load the configuration, but would continue to function normally until UDPTL configuration was needed by a consumer at which point it would fail to find the global UDPTL configuration and fail, often without displaying a good reason for the failure.
> 
> 
> Diffs
> -----
> 
>   /branches/11/main/udptl.c 397192 
> 
> Diff: https://reviewboard.asterisk.org/r/2773/diff/
> 
> 
> Testing
> -------
> 
> Compared the differences before and after the patch with the following:
> 
> 1. No udptl.conf present in /etc/asterisk
> 2. load Asterisk
> 3. issue comand udptl show config
> 
> prior to patch:
> 
> *CLI> udptl show config
> Command 'udptl show config ' failed.
> 
> 
> after the patch:
> 
> *CLI> udptl show config 
> UDPTL Global options
> --------------------
> udptlstart:      4000
> udptlend:        4999
> udptlfecentries: 0
> udptlfecspan:    0
> use_even_ports:  No
> udptlchecksums: Yes
> 
> 
> Seems pretty open and shut to me.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130821/87e95bb2/attachment.htm>