[asterisk-dev] [Code Review] 2761: Fix several interrelated issues dealing with the holding bridge technology.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2761/
-----------------------------------------------------------

(Updated Aug. 20, 2013, 6:55 p.m.)


Review request for Asterisk Developers.


Changes
-------

Freshen patch from logical conflict.


Repository: Asterisk


Description
-------

* Added an option flags parameter to interval hooks.  Interval hooks now can specify if the callback will affect the media path or not.

* Added an option flags parameter to the bridge action custom callback.  The action callback now can specify if the callback will affect the media path or not.

* Made the holding bridge technology reexamine the participant idle mode option whenever the entertainment is restarted.

* Fixed app_agent_pool waiting agents needlessly starting and stopping MOH every second by specifying the heartbeat interval hook as not affecting the media path.

* Fixed app_agent_pool agent alert from restarting the MOH after the alert beep.  The agent entertainment is now changed from MOH to silence after the alert beep.

* Fixed holding bridge technology to defer starting the entertainment.  It was previously a mixture of immediate and deferred.

* Fixed holding bridge technology to immediately stop the entertainment.  It was previously a mixture of immediate and deferred.  If the channel left the bridging system, any deferred stopping was discarded before taking effect.

* Miscellaneous holding bridge technology rework coding improvements.


Diffs (updated)
-----

  /trunk/apps/app_agent_pool.c 397192 
  /trunk/apps/app_bridgewait.c 397192 
  /trunk/bridges/bridge_builtin_interval_features.c 397192 
  /trunk/bridges/bridge_holding.c 397192 
  /trunk/include/asterisk/bridge_channel.h 397192 
  /trunk/include/asterisk/bridge_features.h 397192 
  /trunk/main/bridge.c 397192 
  /trunk/main/bridge_channel.c 397192 
  /trunk/main/features.c 397192 
  /trunk/res/parking/parking_bridge_features.c 397192 

Diff: https://reviewboard.asterisk.org/r/2761/diff/


Testing
-------

* Waiting agents no longer start and stop MOH every second.  (Tests the interval hook options flag parameter.)
* Waiting agents hear the alerting beep followed by silence again. (Tests the holding bridge reexamining the idle mode option.)
* Tested BridgeWait announcer and participant entering leaving combinations.  They still work.  (Tests entertainment starting and stopping.)


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130820/a200d5e7/attachment.htm>