[asterisk-dev] [Code Review] 2728: Allow the SIP_CODEC family of variables to specify more than one codec

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2728/
-----------------------------------------------------------

(Updated Aug. 19, 2013, 11:36 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed Walter's findings.


Bugs: ASTERISK-21976
    https://issues.asterisk.org/jira/browse/ASTERISK-21976


Repository: Asterisk


Description
-------

{quote}
For video calls, we would like to set the codecs in the dialplan using 
SIP_CODEC. However, if SIP_CODEC is set, all codecs except the ONE set are disallowed and thus either audio or video is available.
Attached is a patch for 11.4 that allows SIP_CODEC to contain a list of codecs , e.g. "gsm,h264".
{quote}

As an aside, chan_pjsip has an analogous dialplan function "PJSIP_MEDIA_OFFER". While this doesn't allow for setting multiple codecs, it does handle multiple media types, as you can specify both video or audio for the codec you want to apply - hence I didn't port this patch/feature over to chan_pjsip. If we think it needs it, it would be reasonably easy to do so.


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 396943 

Diff: https://reviewboard.asterisk.org/r/2728/diff/


Testing
-------


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130819/51d673f0/attachment.htm>