[asterisk-dev] [Code Review] 2769: ARI: Correct error codes for bridge operations

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2769/
-----------------------------------------------------------

(Updated Aug. 19, 2013, 2:53 p.m.)


Review request for Asterisk Developers.


Changes
-------

Added link to testsuite patch


Bugs: ASTERISK-22036
    https://issues.asterisk.org/jira/browse/ASTERISK-22036


Repository: Asterisk


Description
-------

This patch adds error checking to ARI bridge operations, when
adding/removing channels to/from bridges.

In general, the error codes fall out as follows:
 * Bridge not found - 404 Not Found
 * Bridge not in Stasis - 409 Conflict
 * Channel not found - 400 Bad Request
 * Channel not in Stasis - 422 Unprocessable Entity
 * Channel not in this bridge (on remove) - 422 Unprocessable Entity


Diffs
-----

  /trunk/include/asterisk/stasis_app.h 396938 
  /trunk/include/asterisk/stasis_app_impl.h 396938 
  /trunk/res/ari/resource_bridges.c 396938 
  /trunk/res/res_ari_bridges.c 396938 
  /trunk/res/stasis/control.c 396938 
  /trunk/rest-api/api-docs/bridges.json 396938 

Diff: https://reviewboard.asterisk.org/r/2769/diff/


Testing (updated)
-------

Testsuite tests! (Review to be posted shortly)

https://reviewboard.asterisk.org/r/2770/


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130819/fbee61f9/attachment.htm>