[asterisk-dev] [Code Review] 2767: Testsuite: fix pjsip tests for identifying by host

[jbigelow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2767/
-----------------------------------------------------------

Review request for Asterisk Developers and Mark Michelson.


Repository: testsuite


Description
-------

The pjsip tests that identify by host are actually being identified by user. This patch allows the inbound calls to be identified by host/IP as they once were but in a different way.

It appears this was caused by revision 3967 when the modules.conf files were removed from the tests which loaded just one of the identifier modules being res_pjsip_endpoint_identifier_ip.so. Now without the modules.conf files, Asterisk loads the res_pjsip_endpoint_identifier_user.so module first before the other identifier modules thus identifying by user first.

By changing the From header in the scenarios, a user/endpoint won't be matched allowing them to be identified by host/IP as intended. I figured this was a better solution rather than adding a modules.conf to the tests containing a noload for res_pjsip_endpoint_identifier_user.so


Diffs
-----

  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/configs/ast1/pjsip.conf 4025 
  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/sipp/echo_with_deferred_sdp.xml 4025 
  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/sipp/echo_with_initial_sdp.xml 4025 
  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/sipp/playback_with_deferred_sdp.xml 4025 
  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/sipp/playback_with_initial_sdp.xml 4025 
  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/configs/ast1/pjsip.conf 4025 
  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/sipp/echo_with_deferred_sdp.xml 4025 
  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/sipp/echo_with_initial_sdp.xml 4025 
  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/sipp/playback_with_deferred_sdp.xml 4025 
  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/sipp/playback_with_initial_sdp.xml 4025 
  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/configs/ast1/pjsip.conf 4025 
  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/sipp/echo_with_deferred_sdp.xml 4025 
  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/sipp/echo_with_initial_sdp.xml 4025 
  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/sipp/playback_with_deferred_sdp.xml 4025 
  /asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/sipp/playback_with_initial_sdp.xml 4025 

Diff: https://reviewboard.asterisk.org/r/2767/diff/


Testing
-------

* Verified that the logs do not contain the Asterisk debug message "Retrieved endpoint %s" since the calls are being identified by host/IP instead.
* Ensured the tests pass


Thanks,

jbigelow

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130816/a8f3b739/attachment-0001.htm>