[asterisk-dev] [Code Review] 2763: Allow res_parking to be unloadable

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2763/
-----------------------------------------------------------

(Updated Aug. 16, 2013, 3:14 p.m.)


Review request for Asterisk Developers and jrose.


Changes
-------

Push parking module ref counting to the parking stubs and do some other cleanup as per Richard's comments.


Bugs: ASTERISK-22142
    https://issues.asterisk.org/jira/browse/ASTERISK-22142


Repository: Asterisk


Description
-------

This change protects accesses of res_parking such that it can unload safely once transient uses of its registered functions are complete. The parking API has been restructured such that its consumers do not have access to the vtable exposed by the parking provider, but instead route through stubs to prevent consumers from holding on to function pointers.

This adds calls to all the parking unload functions and moves application loading and unloading into functions in parking_applications.c similar to the rest of the parts of res_parking.


Diffs (updated)
-----

  /trunk/channels/chan_dahdi.c 396876 
  /trunk/channels/chan_skinny.c 396876 
  /trunk/channels/sig_analog.c 396876 
  /trunk/include/asterisk/parking.h 396876 
  /trunk/main/bridge.c 396876 
  /trunk/main/bridge_channel.c 396876 
  /trunk/main/parking.c 396876 
  /trunk/res/parking/parking_applications.c 396876 
  /trunk/res/parking/parking_bridge_features.c 396876 
  /trunk/res/parking/res_parking.h 396876 
  /trunk/res/res_parking.c 396876 

Diff: https://reviewboard.asterisk.org/r/2763/diff/


Testing
-------

Unloaded and reloaded res_parking ensuring that created dialplan was removed and that tests passed once reloaded.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130816/dce9e018/attachment.htm>