[asterisk-dev] [Code Review] 2743: quickfix against ast_log infinite recursion when out of memory
svnbot
reviewboard at asterisk.org
Fri Aug 16 02:19:03 CDT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2743/
-----------------------------------------------------------
(Updated Aug. 16, 2013, 2:19 a.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers.
Changes
-------
Committed in revision 396822
Repository: Asterisk
Description
-------
Dirty quickfix to tackle ast_log() killing the asterisk when we're out of memory.
I don't like this fix at all. But I like the problem even less.
If anyone has a better idea, do come forward. (Aside from fixing the problem that caused me to run out of memory in the first place. But that's for another day.)
Diffs
-----
/trunk/include/asterisk/utils.h 396318
/trunk/main/pbx.c 396318
/trunk/main/utils.c 396318
Diff: https://reviewboard.asterisk.org/r/2743/diff/
Testing
-------
When MALLOC_DEBUG is disabled,
CLI> core eat memory
did what it's supposed to do: without the patch, asterisk crashed (stack full). With it, it didn't.
Thanks,
wdoekes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130816/15b772d3/attachment.htm>
More information about the asterisk-dev
mailing list