[asterisk-dev] [Code Review] 2759: Fix feature_attended_transfer test

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2759/#review9405
-----------------------------------------------------------

Ship it!


Ship It!

- rmudgett


On Aug. 14, 2013, 6:34 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2759/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 6:34 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and rmudgett.
> 
> 
> Bugs: ASTERISK-22222
>     https://issues.asterisk.org/jira/browse/ASTERISK-22222
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The feature_attended_transfer test is failing due to Asterisk not passing DTMF in the bridges created for internal attended transfers. This sets the features initialization routine to set this flag by default and adjusts the basic bridge and confbridge's use of the bridging system accordingly as per Richard's suggestion instead of adjusting this individual case. This change allows the necessary DTMF to pass through the attended transfer bridge and complete the test successfully.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_confbridge.c 396558 
>   trunk/main/bridge.c 396558 
>   trunk/main/features.c 396558 
> 
> Diff: https://reviewboard.asterisk.org/r/2759/diff/
> 
> 
> Testing
> -------
> 
> The feature_attended_transfer test now passes and executes events as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130814/e084269c/attachment-0001.htm>