[asterisk-dev] [Code Review] 2752: Fix Bridge API DTMF hook matching for begin and end DTMF events.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2752/#review9403
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On Aug. 8, 2013, 4:59 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2752/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2013, 4:59 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22037
>     https://issues.asterisk.org/jira/browse/ASTERISK-22037
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The Bridge API DTMF hook matching would not deal with DTMF end events only.  It required a DTMF begin event to start matching the DTMF hooks.  There are many places in Asterisk where code only generates DTMF end events without the corresponding begin event.  One such place is the AMI action Atxfer.
> 
> * Fixed DTMF hook matching if there is a string of DTMF frames in the read queue.  We could potentially miss some of them before.
> 
> * Fixed AMI Atxfer action documentation.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/bridge_channel.c 396397 
>   /trunk/include/asterisk/bridge_channel_internal.h 396397 
>   /trunk/main/manager.c 396397 
> 
> Diff: https://reviewboard.asterisk.org/r/2752/diff/
> 
> 
> Testing
> -------
> 
> The normal DTMF atxfer still works.
> The AMI action Atxfer now works as expected with this patch.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130814/c41a1336/attachment.htm>