[asterisk-dev] [Code Review] 2756: Fix deadlocks in chan_sip in REFER and BYE handling

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2756/
-----------------------------------------------------------

(Updated Aug. 13, 2013, 12:52 p.m.)


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

Address Mark's comments and shuffle things around a little to reduce the number of locking dances.


Bugs: ASTERISK-22215
    https://issues.asterisk.org/jira/browse/ASTERISK-22215


Repository: Asterisk


Description
-------

This resolves several deadlocks in chan_sip relating to usage of ast_channel_bridge_peer and improves accessibility of lock debugging function calls.

These issues were found while fixing the sip attended transfer integration tests for the referenced bug.


Diffs (updated)
-----

  trunk/channels/chan_sip.c 396558 
  trunk/include/asterisk/lock.h 396558 
  trunk/main/utils.c 396558 

Diff: https://reviewboard.asterisk.org/r/2756/diff/


Testing
-------

With these changes, chan_sip no longer stalls part of the way through the rewritten sip attended transfer tests on the REFER or at the end on the final BYE.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130813/19cdb35a/attachment.htm>