[asterisk-dev] [Code Review] 2733: pjsip tests: Test configuration options for nominal inbound registrations

[jbigelow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2733/
-----------------------------------------------------------

(Updated Aug. 12, 2013, 3:57 p.m.)


Review request for Asterisk Developers.


Changes
-------

Note that these tests depend on the test suite events under review 2700


Repository: testsuite


Description (updated)
-------

This test sends registrations over IPv4/IPv6 and UDP/TCP to test the pjsip.conf configuration options minimum_expiration, maximum_expiration, and remove_existing. This covers tests 4, 5, and 6 of the nominal inbound registrations listed on the test plan page of the wiki.

These tests depend on some test suite events. See review 2700 ( https://reviewboard.asterisk.org/r/2700/ ).

Tests:
* minimum_expiration - register a contact where the Expires header and the expires parameter on the contact are lower than the value set for the minimum_expiration configuration option. This is to ensure the value of minimum_expiration is used.

* maximum_expiration - register a contact where the Expires header and the expires parameter on the contact are higher than the value set for the maximum_expiration configuration option. This is to ensure the value of maximum_expiration is used.

* remove_existing - register two contacts per AOR. Then register two different contacts for the same AORs. This ensures that with the remove_existing configuration option enabled, the first two contacts are removed and the new contacts are added.


Diffs
-----

  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/maximum_expiration/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/maximum_expiration/sipp/register-noauth.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/maximum_expiration/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/minimum_expiration/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/minimum_expiration/sipp/register-noauth.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/minimum_expiration/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/remove_existing/configs/ast1/pjsip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/remove_existing/sipp/register-noauth-ipv4.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/remove_existing/sipp/register-noauth-ipv6.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/remove_existing/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/config_options/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/inbound/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/registration/tests.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/pjsip/tests.yaml 3972 

Diff: https://reviewboard.asterisk.org/r/2733/diff/


Testing
-------

* Ensured the tests fail if:
- the Test Events aren't received or do not match. (all tests)
- the expires parameter of the contact header in the 200 OK isn't what is expected. (minimum_expiration & maximum_expiration)
- the old contacts are present or the max contacts are reached. (remove_existing)
* Reviewed logs to ensure that the registrations were using all the combinations of IPv4/IPv6 and UDP/TCP. (all test)


Thanks,

jbigelow

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130812/625c03de/attachment-0001.htm>