[asterisk-dev] [Code Review] 2739: Test Suite test event for review 2736

[initialjiang]

Hello

I want to kown that who are you?

Why you send so many emails to me??!





At 2013-08-10 06:50:26,jbigelow <reviewboard at asterisk.org> wrote:

| This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2739/ |



On August 5th, 2013, 1:03 p.m. CDT, Matt Jordan wrote:

| /trunk/res/res_pjsip_registrar.c (Diff revision 1) |
|
static int registrar_prune_static(void *obj, void *arg, int flags)
|
| |
| 150 |
ast_verb(3,"Removed contact '%s' from AOR '%s' due to request\n",contact->uri,aor_name);
|
I'm not sure this should be a verbose message. Verbose messages are usually shown to indicate dialplan execution - this message would show up with very little context.

I'd personally make it a debug message.
This same verbose message is used else where in the code. Asterisk 11 and older have a verbose message when a peer is unregistered which is essentially the equivalent here.



- jbigelow




On August 9th, 2013, 5:46 p.m. CDT, jbigelow wrote:

|
Review request for Asterisk Developers.
By jbigelow.

Updated Aug. 9, 2013, 5:46 p.m.

Repository: Asterisk
Description
|
Test Suite test event for review 2736 (https://reviewboard.asterisk.org/r/2736/).
|
Testing
|
Events are received when using '*' in the Contact header to unregister all contacts.
|
Diffs
/trunk/res/res_pjsip_registrar.c (396156)

View Diff

|
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130810/1b9d5a8f/attachment.htm>