[asterisk-dev] [Code Review] 2748: pbx outgoing: Fix a bug that is causing ACL testsuite tests to fail.

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2748/
-----------------------------------------------------------

(Updated Aug. 9, 2013, 7:19 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers, Joshua Colp, kmoore, and Matt Jordan.


Bugs: ASTERISK-22212
    https://issues.asterisk.org/jira/browse/ASTERISK-22212


Repository: Asterisk


Description
-------

The cause of these test failures is that originate manager actions are no longer indicating that the originate action fails when a dial operation fails due to originates all getting a separate thread to dial with now. The fix was relatively trivial and is contained entirely in pbx.c

In addition, I have a patch to chan_sip which fixes a segfault crash (which turns out not to have been involved in the test failures) when an ACL denies an address for verifying registration. The condition for publishing a stasis endpoint blob just made a bad assumption that the peer wouldn't be NULL at that point.


Diffs
-----

  /trunk/channels/chan_sip.c 396364 
  /trunk/main/pbx.c 396364 

Diff: https://reviewboard.asterisk.org/r/2748/diff/


Testing
-------

Ran all ACL related tests, checked registrations against peers with ACL

I have some changes planned for the SIP and IAX ACL tests which should make it easier to understand where a stall in the test occurs and what expectations failed to be met in the process.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130809/1a6da3a6/attachment.htm>